src: support import() and import.meta in embedder-run modules #61654
+320
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a embedder_module_hdo for identifying embedder-run modules in the dynamic import handler and import.meta initializer, and a SourceTextModuleTypes for customizing source text module compilation in the JS land via compileSourceTextModule(). Also, refactors the existing embedder module compilation code to reuse the builtin resolution logic.
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
legendecas
reviewed
Feb 3, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61654 +/- ##
==========================================
+ Coverage 89.74% 89.76% +0.01%
==========================================
Files 674 674
Lines 204348 204495 +147
Branches 39271 39294 +23
==========================================
+ Hits 183396 183564 +168
+ Misses 13262 13215 -47
- Partials 7690 7716 +26
🚀 New features to boost your workflow:
|
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
Collaborator
Aditi-1400
reviewed
Feb 5, 2026
Contributor
Aditi-1400
left a comment
Aditi-1400
left a comment
There was a problem hiding this comment.
Should we add a rejection test for non-builtin imports? 🤔
joyeecheung
force-pushed
the
api-import-meta
branch
from
548d620 to
5182318
Compare
Member
Author
|
Added tests for rejections from dynamic import(). PTAL, thanks @legendecas @Aditi-1400 |
legendecas
approved these changes
Feb 8, 2026
github-actions
bot
removed
the
request-ci
Collaborator
Aditi-1400
approved these changes
Feb 9, 2026
joyeecheung
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 911b158 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a embedder_module_hdo for identifying embedder-run modules in the dynamic import handler and import.meta initializer, and a SourceTextModuleTypes for customizing source text module compilation in the JS land via compileSourceTextModule(). Also, refactors the existing embedder module compilation code to reuse the builtin resolution logic.